52
Avoiding if-else Hell: The Functional Style
(lackofimagination.org)
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Follow the wormhole through a path of communities !webdev@programming.dev
Looks like it’s JavaScript, but in Java I would prefer to use the Stream API, something like this:
Then we have:
This increases the separation of concern in a neat way, and it becomes more clear what the for loop does at a glance (get the first driver satisfying a set of conditions). The more complicated logic is isolated in meetsRiderPreferences, which now only returns true or false. Reading the method is more about making a mental map of a truth table.
It’s also easy to expand the logic (add more filter conditions, sort the drivers based on rating and distance, break out meetsRiderPreferences into smaller methods, etc.).
Not sure how the equivalent in JavaScript would look like, but this is what I would do in Java.
Using early returns and ternary conditional operator changes
to
dunno if java has them, but in C# switch expressions could put more of a case focus on the cases
or with a body expression
The conditional has a true result so it can be converted to a simple bool condition as well.
I try to prefer
.findAny()
over.findFirst()
because it will perform better in some cases (it will have to resolve whether they are other matches and which one is actually first before they can terminate - more relevant for parallel streams I think. findAny short circuits that) but otherwise I like the first. I'd probably go with some sort of composed predicate for the second, to be able to easily add new criteria. But I could be over engineering.I mostly just posted because I think not enough people are aware of the reasons to use findAny as a default unless findFirst is needed.
For me I have the habit of doing findFirst because determinism is important where I work. But I agree with you if determinism is not of importance.