32
Unsigned Commits
(blog.glyph.im)
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 25 Jan 2024
32 points (88.1% liked)
Programming
17314 readers
95 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 1 year ago
MODERATORS
Great read.
I agree about the culture problem. People want to slap extra encryption into things, like a spoiler on a hatchback.
The core issue is that the problem being addressed by signed commits is already solved.
Did MajorHavoc write this commit?
If it has my username, on GitHub, you're confident it's my commit.
Alternately, it could be someone with so much access to my SSH keys, or to GitHib's infrastructure, that they could easily sign commits as me, anyway.
Signed commits might become more compelling when we start to favor fully open source federated git solutions. At that point, if I'm famously trustworthy, and the repo I submitted a signed commit to is not, then my signature could mean something.
But even then, there's the risk that someone interprets my 4 minute typo fix as my having some clue whether the repo is actually safe to use...
Apparently, that's not true: https://dev.to/martiliones/how-i-got-linus-torvalds-in-my-contributors-on-github-3k4g
However, it's a pretty old article - maybe it's already fixed? I'll have to try that.
EDIT: It still works, and you can just use the github noreply address, which is ID+username@users.noreply.github.com . The commit gets linked to their profile, and is shown on their profile page, has their username and profile picture. I haven't figured out any difference between legit and impersonated commit so far, but maybe it's hidden somwhere in the repo administration.
So, there you have it. That's what PGP signing is for.
Nice.
That's enough to make me reconsider signing. Thanks!
Anyone can slap your name and email on a commit and pretend you wrote it
On GitHub, the account that pushed the commit is already fairly evident.
Commits pushed from my GitHub account are differentiated from commits that are not.
I don't want huge centralized Git infrastructure, but while we have it, signed commits are less compelling.
And I'm not saying I love the current state of code authorship verification, either.