I try and keep services that support my pipelines outside of these kinds of things.

Doesn't seem like a problem unless the gitops controller is managing repositories too.

This isn't a cyclic dependency, and doesn't affect failure modes. If the git server fails, the gitops controller fails or waits.

It's a bit more of a problem if the cluster IaC itself is managed using this git instance, but that's easy enough to solve with backups or not doing that.

Since this is a home lab, none of this is problematic. Feel free to condense everything - even the backup controller. Just make sure you have a way to access data and manually intervene if it shits the bed.

Just be careful how much you depend on the git repo for Flux.

I made the mistake of doing the same thing but took it a two further and used Gitea for my container images and helm charts. When I messed up Gitea during an ArgoCD sync, I couldn't roll back because the custom helm chart for Gitea and Postgres came from Gitea.

It also messed up every other application and ended up deleting all my resources during auto sync.

Best thing I ended up doing was mirroring Gitea to GitHub, including images and charts. Then using that for ArgoCD.