38

For context, I am trying to do a save system for a game.

you are viewing a single comment's thread
view the rest of the comments
[-] Gyroplast@pawb.social 15 points 3 weeks ago

Generally speaking, there is a race condition lurking where the OS may do whatever to your file you just checked, rendering the check strictly obsolete the moment you get the result. This isn't typical, but possible, and a lovely old-school security vulnerability class. :)

A more practical argument is that you're going to handle any errors your open() may throw, anyway, and therefore it's simply redundant to check for file existence explicitly beforehand.

Under specific circumstances, you may want to do explicit, very specific tests for more detailed error reporting than "error opening file!", for example "save file is corrupted" if it's too short or zero-length, or "save file directory is gone. What the hell, dude? Recreating it, but stop fiddling with my files!"

This is easy to overengineer. Best is to get into the very sensible habit of always checking for errors or exceptions returned by your calls, and this will become a non-issue.

In this particular use-case of save file loading, you might implement displaying a listing of save files in a directory with opendir/readdir or FindFirstFile/FindNextFile and its ilk, to offer a list of files to load, which doubles as a crude existence test already. Many ways lead away from Rome. If you're considering loading an autosave and offer a "Continue" button or something, a cheap existence test would work very well to decide if that button needs to be displayed in the first place, but doesn't free you from handling any open() errors later. You could also open() and validate an autosave directly, and when/if the user decides to "Continue", use the already reserved file descriptor and maybe even the preloaded save data to quickly jump into the game.

If you want a simple answer: Do not introduce race conditions. Always acquire a lock for a shared resource before doing anything with it.

this post was submitted on 01 Sep 2024
38 points (100.0% liked)

Learn Programming

1616 readers
1 users here now

Posting Etiquette

  1. Ask the main part of your question in the title. This should be concise but informative.

  2. Provide everything up front. Don't make people fish for more details in the comments. Provide background information and examples.

  3. Be present for follow up questions. Don't ask for help and run away. Stick around to answer questions and provide more details.

  4. Ask about the problem you're trying to solve. Don't focus too much on debugging your exact solution, as you may be going down the wrong path. Include as much information as you can about what you ultimately are trying to achieve. See more on this here: https://xyproblem.info/

Icon base by Delapouite under CC BY 3.0 with modifications to add a gradient

founded 1 year ago
MODERATORS