This is bullshit because it’s not a 1% / 99% split.

The successes are more common than the failures in my experience. They’re absolutely not “exponentially rarer than the failures.” I work with many successful veterans, all of us are near or above six figure salaries from our civilian jobs, not counting any military benefits. I’m one of those. My wife is an active duty officer. I got out after I did the minimum time to get the benefits I was after, because I like smoking weed and having a beard. I had a plan to pay off my college debt and get experience in the field. I pulled it off, and even got to travel to Japan and live in Italy. I got even more education benefits for reenlisting for a couple years.

Yeah, I know of a few suicides. I know of a few suicides and drug overdoses from civilian life, too. Divorce rates are astronomical on the enlisted side, I’ll give you that.

What fast food job can get you a career and college afterwards? You won’t get decent healthcare, nor room and board, nor an opportunity to travel with a fast food job.

Not every job in the military is infantry. It’s got more risks than a typical civilian job, but it’s absolutely not the 1%/99% split you’re claiming. Most people make it out fine and it sets them up well for life afterwards. That doesn’t mean you’re guaranteed success, though, and some people treat it this way. It is what you make of it.

Here's a source corroborating my experience with veterans:

"New York's 9/11-Era Veterans: A Quantitative Study by Sex, Race, and E" by Lawrence Cappello

9/11 era veterans in the New York metropolitan area performed well above their non-veteran counterparts in most socio-economic categories. The data indicate that between 2007 and 2017 employment, income, and educational attainment rates were consistently higher, and poverty rates consistently lower, than those of the metro area’s general population. These trends held relatively firm during the financial crisis of 2008 and as the veteran population continued to grow into the 2010s. In short, there is considerable evidence within this report to affirm that serving in the armed forces continues to have a direct correlation with greater socio-economic success. This correlation is particularly stark among Latinos and non-Hispanic blacks, where the variances between their non-veteran counterparts are prevalent in income, employment, poverty rates, and educational attainment.

There's a lot of statistics that can be found in this Pew research article too. I believe this sums it up well. Sure doesn't sound like only 1% have a successful experience.

A large majority of veterans endorse the military as a career choice. Roughly eight-in-ten say they would advise a young person close to them to join the military. This includes large majorities of post-9/11 veterans, combat veterans and those who say they had emotionally traumatic experiences in the military.