Most rhythm games are better on keyboard except for project diva which is way better on controller. I think osu! is the least controller friendly rhythm game and osu!mania style rhythm games are probably impossible on controller if it needs more than 6 keys (unless the charts are designed for controller and don't require hitting every button at once).

Project diva feels really bad to play on keyboard for some reason. I think its because its only recently been playable on pc and I'm used to controller. It just feels better on thumbs.