707

I am God's greatest programmer (lemmy.world)

submitted 1 year ago by bigboismith@lemmy.world to c/programmer_humor@programming.dev

47 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] ryan@the.coolest.zone 139 points 1 year ago

Let him play in the legacy code. You can just hose him off later before letting him back into the office so he doesn't track it everywhere.

[-] ISometimesAdmin@the.coolest.zone 64 points 1 year ago

Unfortunately if you let Junior play in legacy code once, it'll learn some nasty habits and make more of it from scratch, usually when you're trying to sleep.

[-] MonkderZweite@feddit.ch 5 points 1 year ago* (last edited 1 year ago)

That's what the line represents. So they can pull you if you do something nasty.

[+] BaardFigur@lemmy.world 13 points 1 year ago* (last edited 1 year ago)

[deleted]

[-] CodeMonkey@programming.dev 10 points 1 year ago

If you are creating an alternative implementation and leaving the old one in place, you are not fixing a problem, you are just creating a new one (and a third one because you have duplication of logic).

Either refactor the old function so that it transparently calls the new logic or delete the old function and replace all the existing usage with usage of the new one. It does not need to happen as a single commit. You can check in the new function, tell everyone to use it, and clean up usage of the old one. If anyone tries to use the old implementation, call them out in a code review.

If removing or replacing the old implementation is not possible, at least mark it as deprecated so that anyone using it gets a warning.