is it worth learning docker and deploying all my services that way or should I just continue with the way i have been doing it for years now?

100% worth!

It is really amazing approach that eases so many aspects and makes you feel more in control and more willing to try stuff.

This repository should be helpful.

Examples of bunch of popular services running in docker and some other stuff like backups with borg or kopia.

using Arch for my home server

I too run Arch as my go-to linux server, usually docker host is being its main job. Sometimes wireguard node or NUT sever for UPS.

Reason being its a damn good OS and I am most comfortable with it since I am running it on my main desktop. But another thing is that I usually run under some hypervisor(hyper-v and esxi) as a virtual machine, not straight on metal. So taking snapshot of it is matter of second and reverting to that snapshot is a minute... so that is one aspect that lets me go with any linux I damn like without that much consideration for reputation of stability.

That repo that I linked has even notes on arch fresh install, but arch started to include archinstall script on ISO, i decided to rather use that.

I started to deploy Arch so much that I even have few ansible playbooks to get arch the way I like. Which mostly means some basic services and packages and workflow being about nnn file manager and micro text editor.

Also recommend you use lts kernel when installing arch, just for that extra stability.

Also it seem you were running xorg too, which I recommend abandoning. So much extra packages, so much more that can go wrong on update compared to bare arch with terminal and ssh.. but if it really ease your workflow then fine.