9

In VS I am told this function "does not return a value in all control paths." A bot told me specifically the issue is with this line: else if (letter + key <= 90). It said that if the outcome results in letter + key equally exactly 90 then a value is not returned, but I thought that was covered where '<=' means 'less than or equals.'

char rotate(char letter, int key)
{
    if (isalpha(letter) == true)
    {
        if (letter + key > 90)
        {
            int overage = letter + key - 90;
            letter = 64 + overage;

            while (letter > 90)
            {
                overage = letter - 90;
                letter += overage;
            }

            return letter;
        }

        else if (letter + key &lt;= 90)
        {
            letter += key;
            return letter;
        }
    }

    else if (isalpha(letter) == false)
    {
        return letter;
    }
you are viewing a single comment's thread
view the rest of the comments
[-] towerful@programming.dev 20 points 1 year ago* (last edited 1 year ago)

I'm a fan of early returns.
So

if(isalpha(letter) == false) return letter
if(letter whatever) {
   Do thing
   Return letter
}
if(letter something else) {
   Do something else
   Return letter
}
throw error("unprocessable letter")

I find it lets me mentally walk through all the paths more easily.
And if something gets too complex for this, then I need to break it down into further functions

this post was submitted on 16 Nov 2023
9 points (84.6% liked)

Programming

17314 readers
45 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 1 year ago
MODERATORS