9
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 16 Nov 2023
9 points (84.6% liked)
Programming
17314 readers
45 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 1 year ago
MODERATORS
I second the early return suggestions, but the other thing you should be aware of is that
isalpha()
is being evaluated twice unnecessarily. If its cheap and not call frequently, not a real big problem, but it is a waste of cycles. If you want to document the else, you could try:Also, if
isAlpha
was something that could change between evaluation, such asisTuesday
, you are at risk of the first call returning false, and then the second call returning true, which would skip both cases.