567

“the lesson I'm choosing to take from xz, as an oss maintainer, is that anyone trying to pressure or guilt me into doing something should immediately be told no, for security reasons” (crabby.fyi)

submitted 5 months ago by davel@lemmy.ml to c/opensource@lemmy.ml

56 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] zagaberoo@beehaw.org 3 points 5 months ago

"You're dumb" is disrespectful, but "your code is shit" isn't? How does the latter not reasonably imply the former?

Being respectful is taking the time to moderate "your code is shit" to something like "your code is not acceptable". You might even go a modicum further into kindness with "there are aspects of your code I need you to improve".

All express the same idea, some will leave the listener more open to internalizing the criticism.

[-] reverendsteveii@lemm.ee 6 points 5 months ago

How does the latter not reasonably imply the former?

I'm not dumb and I write shit code all the time. Bad code only implies that the author is dumb if you assume only dumb people can make mistakes.

[-] zagaberoo@beehaw.org 1 points 5 months ago

Bad code, yes, calling it 'shit', no.

Stuff like this is a big part of why software circles are seen as so hostile and unwelcoming to outsiders.

You can be completely clear and frank without resorting to insult, mild though it may be. Just because you and people most like you understand that calling their work 'shit' doesn't reflect on them personally, doesn't mean it's not significantly exclusionary.

Now, obviously you can get to know your reports well enough to understand whom would take 'shit' well, but that doesn't mean it's not generally important to temper criticism with kindness. Kindness never has to mean holding back criticism, just avoiding stooping to insult.