354
submitted 1 year ago* (last edited 1 year ago) by drekly@lemmy.world to c/programming@programming.dev

"UPDATE table_name SET w = $1, x = $2, z = $4 WHERE y = $3 RETURNING *",

does not do the same as

"UPDATE table_name SET w = $1, x = $2, y = $3, z = $4 RETURNING *",

It's 2 am and my mind blanked out the WHERE, and just wanted the numbers neatly in order of 1234.

idiot.

FML.

(page 2) 50 comments
sorted by: hot top controversial new old
[-] o11c@programming.dev 5 points 1 year ago

This is about the one thing where SQL is a badly designed language, and you should use a frontend that forces you to write your queries in the order (table, filter, columns) for consistency.

UPDATE table_name WHERE y = $3 SET w = $1, x = $2, z = $4 RETURNING *
FROM table_name SELECT w, x, y, z
load more comments (3 replies)
[-] Bazz@feddit.de 5 points 1 year ago

I don't know if it makes you feel better but Tom Scott had a similar experience: https://youtu.be/X6NJkWbM1xk

[-] evatronic@lemm.ee 4 points 1 year ago

Unrelated, but use placeholders instead of interpolation right into the query.

See: Little Bobby Tables. https://xkcd.com/327/

[-] sim642@lemm.ee 3 points 1 year ago

That's what they're doing...

[-] evatronic@lemm.ee 1 points 1 year ago

If true, great. I've not run across a language / RDBMs library that uses numbered place holders over the standard ?, but I'm sure someone's done it.

[-] books@lemmy.world 4 points 1 year ago

Things like this make me glad I can only query my db.

[-] Techmaster@lemm.ee 4 points 1 year ago

If it's Microsoft SQL you should be able to replay the transaction log. But you should be doing something like daily full backups and hourly incremental or differential backups to avoid this situation in the first place.

[-] fury@lemmy.world 4 points 1 year ago

Pressing F to pay respects. R.I.P. in pieces

Depending on how mission critical your data is...Set up delayed replicas and backups (and test that your backups can actually be restored from). Get a second pair of eyeballs on your query. Set up test environments and run it there before running it in production. The more automated testing you put into your pipeline, the better. Every edit should be committed and tested. (Kubernetes and GitLab Auto DevOps makes this kind of thing a cinch, every branch has a new test environment set up automatically)

Don't beat yourself up too much though. It happens even to seasoned pros.

[-] SeabassDan@lemmy.world 3 points 1 year ago

Ctrl+z bro

Jk, sounds tough

[-] gatelike@feddit.de 2 points 1 year ago

SQL scouts credo: I will never use indexes, I will always use column names.

[-] Wakmrow@lemmy.world 2 points 1 year ago

I learned this lesson too

[-] oldfart@lemm.ee 1 points 1 year ago

Been there, done that, I hope you have a recent backup!

load more comments
view more: ‹ prev next ›
this post was submitted on 11 Oct 2023
354 points (97.6% liked)

Programming

17314 readers
42 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 1 year ago
MODERATORS